Look at the pull request they merged in. Any line added to a script which starts with "rm -rf $VARIABLE" cannot be scrutinized enough.
The first commit was created at: 2012-09-30T10:25:44-07:00.
The pull request was accepted at: 2012-09-30T10:59:08-07:00.
34 minutes to accept on a Sunday morning. I suspect that wasn't 34 minutes of review. I suspect it was closer to 34 seconds of review.
Unacceptable.
Otherwise you're just throwing shit at a wall and seeing what sticks.
Look at the pull request they merged in. Any line added to a script which starts with "rm -rf $VARIABLE" cannot be scrutinized enough.
The first commit was created at: 2012-09-30T10:25:44-07:00.
The pull request was accepted at: 2012-09-30T10:59:08-07:00.
34 minutes to accept on a Sunday morning. I suspect that wasn't 34 minutes of review. I suspect it was closer to 34 seconds of review.
Unacceptable.